lkml.org 
[lkml]   [2022]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses


On 2022-05-22 01:32, Donald Buczek wrote:
>> /*
>> @@ -703,7 +720,7 @@ static void r5c_disable_writeback_async(struct work_struct *work)
>>
>> /* wait superblock change before suspend */
>> wait_event(mddev->sb_wait,
>> - conf->log == NULL ||
>> + rcu_access_pointer(conf->log) ||
>
> Reversed condition?
>
> I think, some examples in Documentation/RCU/Design/Requirements/Requirements.rst are reversed, too.

Oops. Nice Catch!

Thanks,

Logan

\
 
 \ /
  Last update: 2022-05-24 17:58    [W:0.120 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site