Messages in this thread | | | Date | Tue, 24 May 2022 09:55:51 -0600 | From | Logan Gunthorpe <> | Subject | Re: [PATCH v1 12/15] md/raid5-cache: Add RCU protection to conf->log accesses |
| |
On 2022-05-22 01:32, Donald Buczek wrote: >> /* >> @@ -703,7 +720,7 @@ static void r5c_disable_writeback_async(struct work_struct *work) >> >> /* wait superblock change before suspend */ >> wait_event(mddev->sb_wait, >> - conf->log == NULL || >> + rcu_access_pointer(conf->log) || > > Reversed condition? > > I think, some examples in Documentation/RCU/Design/Requirements/Requirements.rst are reversed, too.
Oops. Nice Catch!
Thanks,
Logan
| |