Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 24 May 2022 14:30:36 +0200 | Subject | Re: [PATCH] misc: rtsx: Fix clang -Wsometimes-uninitialized in rts5261_init_from_hw() |
| |
On Mon, May 23, 2022 at 5:05 PM Nathan Chancellor <nathan@kernel.org> wrote: > > Clang warns: > > drivers/misc/cardreader/rts5261.c:406:13: error: variable 'setting_reg2' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > } else if (efuse_valid == 0) { > ^~~~~~~~~~~~~~~~ > drivers/misc/cardreader/rts5261.c:412:30: note: uninitialized use occurs here > pci_read_config_dword(pdev, setting_reg2, &lval2); > ^~~~~~~~~~~~ > > efuse_valid == 1 is not a valid value so just return early from the > function to avoid using setting_reg2 uninitialized. > > Fixes: b1c5f3085149 ("misc: rtsx: add rts5261 efuse function") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Tom Rix <trix@redhat.com> > Suggested-by: Ricky WU <ricky_wu@realtek.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Looks good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |