lkml.org 
[lkml]   [2022]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/7] dt-bindings: soc: add bindings for i.MX93 mediamix blk ctrl
From
On 23/05/2022 13:30, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add DT bindings for i.MX93 MEDIAMIX BLK CTRL.

In the subject - you duplicate "bindings", so just "dt-bindings: soc:
add i.MX93 mediamix blk ctrl"

>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 81 +++++++++++++++++++
> include/dt-bindings/power/imx93-power.h | 6 ++
> 2 files changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
> new file mode 100644
> index 000000000000..775c08d763b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/imx/fsl,imx93-media-blk-ctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX93 Media blk-ctrl
> +
> +maintainers:
> + - Peng Fan <peng.fan@nxp.com>
> +
> +description:
> + The i.MX93 MEDIAMIX domain contains control and status registers known
> + as MEDIAMIX Block Control (MEDIAMIX BLK_CTRL). These registers include
> + clocking, reset, and miscellaneous top-level controls for peripherals
> + within the MEDIAMIX domain
> +
> +properties:
> + compatible:
> + items:
> + - const: fsl,imx93-media-blk-ctrl
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + '#power-domain-cells':
> + const: 1

Missing ref to power domains.

> +
> + power-domains:
> + maxItems: 1
> +
> + clocks:
> + minItems: 10

minItems is not needed in such case.

> + maxItems: 10
> +
> + clock-names:
> + items:
> + - const: apb
> + - const: axi
> + - const: nic
> + - const: disp
> + - const: cam
> + - const: pxp
> + - const: lcdif
> + - const: isi
> + - const: csi
> + - const: dsi
> +
> +required:
> + - compatible
> + - reg
> + - power-domains
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx93-clock.h>
> + #include <dt-bindings/power/imx93-power.h>
> +
> + media_blk_ctrl: blk_ctrl@4ac10000 {

No underscores in node names. Generic node name, so "system-controller"
or "power-controller"?



Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-05-24 13:21    [W:0.267 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site