lkml.org 
[lkml]   [2022]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] r8152: Return true/false (not 1/0) from bool functions
Date
Return statements in functions returning bool should use true/false
instead of 1/0.

Clean the following coccicheck warning:

./drivers/net/usb/r8152.c:9579:10-11: WARNING: return of 0/1 in function
'rtl8152_supports_lenovo_macpassthru' with return type bool.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/usb/r8152.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 7389d6ef8569..7b7704b4b500 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -9576,15 +9576,15 @@ static bool rtl8152_supports_lenovo_macpassthru(struct usb_device *udev)
case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN2:
case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN3:
case DEVICE_ID_THINKPAD_USB_C_DONGLE:
- return 1;
+ return true;
}
} else if (vendor_id == VENDOR_ID_REALTEK && parent_vendor_id == VENDOR_ID_LENOVO) {
switch (product_id) {
case 0x8153:
- return 1;
+ return true;
}
}
- return 0;
+ return false;
}

static int rtl8152_probe(struct usb_interface *intf,
--
2.20.1.7.g153144c
\
 
 \ /
  Last update: 2022-05-24 11:38    [W:0.514 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site