Messages in this thread | | | Date | Tue, 24 May 2022 11:20:05 +0200 | Subject | Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Kobo Aura 2 | From | Krzysztof Kozlowski <> |
| |
On 23/05/2022 21:05, Andreas Kemnade wrote: > On Mon, 23 May 2022 12:03:09 +0200 > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > [...] >>> + >>> + gpio_keys: gpio-keys { >>> + compatible = "gpio-keys"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_gpio_keys>; >>> + >>> + cover { >> >> Generic node names. You could add suffix if needed, so either key or >> key-cover. >> > hmm, the example in > Documentation/devicetree/bindings/input/gpio-keys.yaml > > shows names like I did. I usually expect to trust binding documentation > to have something acceptable.
It's only an example and no one usually cares about correcting it, once it got merged.
Best regards, Krzysztof
| |