Messages in this thread | | | From | "G, GurucharanX" <> | Subject | RE: [Intel-wired-lan] [PATCH] ice: Use correct order for the parameters of devm_kcalloc() | Date | Wed, 25 May 2022 03:14:29 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Christophe JAILLET > Sent: Saturday, May 21, 2022 12:27 PM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; > Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; > Paolo Abeni <pabeni@redhat.com> > Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>; intel-wired- > lan@lists.osuosl.org; kernel-janitors@vger.kernel.org; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] ice: Use correct order for the parameters > of devm_kcalloc() > > We should have 'n', then 'size', not the opposite. > This is harmless because the 2 values are just multiplied, but having the > correct order silence a (unpublished yet) smatch warning. > > While at it use '*tun_seg' instead '*seg'. The both variable have the same > type, so the result is the same, but it lokks more logical. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
| |