lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 11/19] dt-bindings: reset: npcm: Add support for NPCM8XX
From
On 23/05/2022 17:22, Krzysztof Kozlowski wrote:
>> I think you are taking a too-extremist standpoint.
>> The two extremes are:
>> 1. Numbers correspond to hardware numbers, and are easy to look up
>> in the hardware documentation (e.g. GIC SPI interrupt numbers).
>> => Use the hardcoded numbers in DTS.
>
> And such numbers (like GIC_SPI interrupt numbers) do not go to bindings.
> They go to DTS only.
>
>> 2. Numbers do not correspond to hardware numbers, so we had to
>> invent our own definitions and numbers, usually loosely
>> based on some table in the hardware documentation.
>> The driver will have to look up the numbers in a data
>> structure, to know how to program the hardware.
>> The numbers become part of the DT ABI, and cannot be changed
>> (header file is append-only).
>> => Use the binding definitions in DTS.
>
> Correct.
>
> However this patch is some mixture of both approaches.
>
> The same pointed by Arnd:
> https://lore.kernel.org/linux-devicetree/CAK8P3a0fDJQvGLEtG0fxLkG08Fh9V7LEMPsx4AaS+2Ldo_xWxw@mail.gmail.com/

...and one more from Arnd:
https://lore.kernel.org/linux-devicetree/CAK8P3a1APzs74YTcZ=m43G3zrmwJZKcYSTvV5eDDQX-37UY7Tw@mail.gmail.com/



Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-05-23 17:26    [W:0.063 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site