Messages in this thread | | | Date | Mon, 23 May 2022 15:08:16 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: rt4831: Improve error reporting for problems during .remove() |
| |
On Mon, 02 May 2022, Uwe Kleine-König wrote:
> Returning an error value in an i2c remove callback results in a generic > error message being emitted by the i2c core, but otherwise it doesn't make > a difference. The device goes away anyhow and the devm cleanups are > called. > > So instead of triggering the generic i2c error message, emit a more helpful > message if a problem occurs and return 0 to suppress the generic message. > > This patch is a preparation for making i2c remove callbacks return void. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/mfd/rt4831.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-)
Applied, thanks.
-- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |