Messages in this thread | | | Date | Mon, 23 May 2022 11:24:02 +0100 | Subject | Re: [PATCH 0/2] dma-mapping, remoteproc: Fix dma_mem leak after rproc_shutdown | From | Robin Murphy <> |
| |
On 2022-05-23 11:15, Mark-PK Tsai wrote: >> Sigh. In theory drivers should never declare coherent memory like >> this, and there has been some work to fix remoteproc in that regard. >> >> But I guess until that is merged we'll need somthing like this fix. > > Hi, > > Thanks for your comment. > As I didn't see other fix of this issue, should we use this patch > before the remoteproc work you mentioned is merged?
TBH I think it would be better "fixed" with a kmemleak_ignore() and a big comment, rather than adding API cruft for something that isn't a real problem. I'm quite sure that no real-world user is unbinding remoteproc drivers frequently enough that leaking a 48-byte allocation each time has any practical significance.
Thanks, Robin.
| |