Messages in this thread | | | Date | Mon, 23 May 2022 12:16:38 +0200 | Subject | Re: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant | From | Krzysztof Kozlowski <> |
| |
On 20/05/2022 16:58, Tamseel Shams wrote: > From: Alim Akhtar <alim.akhtar@samsung.com> > > This patch adds a new compatible string for FSD-HW's > ADC variant > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > Signed-off-by: Tamseel Shams <m.shams@samsung.com> > --- > - Changes since v1 > * Addressed Krzysztof's comment to use soc-specific compatible > > .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > index 81c87295912c..ded0e3f85991 100644 > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - samsung,exynos-adc-v1 # Exynos5250 > - samsung,exynos-adc-v2 > + - samsung,exynos-adc-fsd-hw
The soc is fsd, so compatible should rather be: tesla,fsd-adc
What does the "HW" mean?
> - samsung,exynos3250-adc > - samsung,exynos4212-adc # Exynos4212 and Exynos4412 > - samsung,exynos7-adc
Best regards, Krzysztof
| |