lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] x86: Fix return value in frequency invariance setup for XEON_PHI_KNL/KNM
From
Date
On Sat, 2022-05-21 at 12:02 +0200, Peter Zijlstra wrote:
> On Fri, May 20, 2022 at 06:10:21PM +0200, Giovanni Gherdovich wrote:
> > knl_set_max_freq_ratio() should return true on success and false
> > otherwise. If the last line of the function body is reached, it means no
> > appropriate value for turbo_freq was found: the setup is unsuccessful and
> > it should return false.
> >
> > Fixes: 8bea0dfb4a82 ("x86, sched: Add support for frequency invariance on XEON_PHI_KNL/KNM")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Giovanni Gherdovich <ggherdovich@suse.cz>
> > ---
> > arch/x86/kernel/smpboot.c | 2 +-
>
> You seems to have missed all that code moved in tip. This no longer
> applies.

Right. I'll rebase and resend. Plus, as per Dave Hansen's comments on
the other patch, I need to have a second look at it.

Giovanni



\
 
 \ /
  Last update: 2022-05-23 11:59    [W:0.118 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site