lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 2/4] soc: mediatek: svs: add support for mt8186
    From
    Il 23/05/22 10:40, Tim Chang ha scritto:
    > From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
    >
    > MT8186 svs has a number of banks which used as optimization of opp
    > voltage table for corresponding dvfs drivers.
    > MT8186 svs big core uses 2-line high bank and low bank to optimize the
    > voltage of opp table for higher and lower frequency respectively.
    >
    > Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
    > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    > ---
    > drivers/soc/mediatek/mtk-svs.c | 351 ++++++++++++++++++++++++++++++++-
    > 1 file changed, 344 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
    > index 606a00a2e57d..656d0361ff7d 100644
    > --- a/drivers/soc/mediatek/mtk-svs.c
    > +++ b/drivers/soc/mediatek/mtk-svs.c

    ..snip..

    > @@ -2245,6 +2569,16 @@ static const struct svs_platform_data svs_mt8192_platform_data = {
    > .bank_max = ARRAY_SIZE(svs_mt8192_banks),
    > };
    >
    > +static const struct svs_platform_data svs_mt8186_platform_data = {
    > + .name = "mt8186-svs",
    > + .banks = svs_mt8186_banks,
    > + .efuse_parsing = svs_mt8186_efuse_parsing,
    > + .probe = svs_mt8186_platform_probe,
    > + .irqflags = IRQF_TRIGGER_HIGH,

    I know I gave you my R-b tag earlier, but I've just noticed that: please remove
    irqflags, as this kind of flags are specified in devicetree and it is not
    necessary to specify them here.

    Thanks,
    Angelo

    \
     
     \ /
      Last update: 2022-05-23 11:39    [W:7.334 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site