Messages in this thread | | | Date | Mon, 23 May 2022 15:58:31 -0700 | Subject | Re: [PATCH v4] bpf: Fix KASAN use-after-free Read in compute_effective_progs | From | Tadeusz Struk <> |
| |
On 5/23/22 15:47, Andrii Nakryiko wrote: >> Hi Andrii, >> Do you have any more feedback? Does it look better to you now? > Hi, this is on my TODO list, but I need a bit more focused time to > think all this through and I haven't managed to get it in last week. > I'm worried about the percpu_ref_is_zero(&desc->bpf.refcnt) portion > and whether it can cause some skew in the calculated array index, I > need to look at this a bit more in depth. Sorry for the delay.
That's fine. take your time and let me know if there is anything else to change/improve. FWIW I tested it extensively with the syzbot repro and the issue doesn't trigger anymore.
-- Thanks, Tadeusz
| |