lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 110/158] net: af_key: add check for pfkey_broadcast in function pfkey_process
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 4dc2a5a8f6754492180741facf2a8787f2c415d7 ]

    If skb_clone() returns null pointer, pfkey_broadcast() will
    return error.
    Therefore, it should be better to check the return value of
    pfkey_broadcast() and return error if fails.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/key/af_key.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/net/key/af_key.c b/net/key/af_key.c
    index fd51db3be91c..92e9d75dba2f 100644
    --- a/net/key/af_key.c
    +++ b/net/key/af_key.c
    @@ -2826,8 +2826,10 @@ static int pfkey_process(struct sock *sk, struct sk_buff *skb, const struct sadb
    void *ext_hdrs[SADB_EXT_MAX];
    int err;

    - pfkey_broadcast(skb_clone(skb, GFP_KERNEL), GFP_KERNEL,
    - BROADCAST_PROMISC_ONLY, NULL, sock_net(sk));
    + err = pfkey_broadcast(skb_clone(skb, GFP_KERNEL), GFP_KERNEL,
    + BROADCAST_PROMISC_ONLY, NULL, sock_net(sk));
    + if (err)
    + return err;

    memset(ext_hdrs, 0, sizeof(ext_hdrs));
    err = parse_exthdrs(skb, hdr, ext_hdrs);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-23 20:15    [W:2.852 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site