lkml.org 
[lkml]   [2022]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 028/158] crypto: stm32 - fix reference leak in stm32_crc_remove
    Date
    From: Zheng Yongjun <zhengyongjun3@huawei.com>

    [ Upstream commit e9a36feecee0ee5845f2e0656f50f9942dd0bed3 ]

    pm_runtime_get_sync() will increment pm usage counter even it
    failed. Forgetting to call pm_runtime_put_noidle will result
    in reference leak in stm32_crc_remove, so we should fix it.

    Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/stm32/stm32-crc32.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/crypto/stm32/stm32-crc32.c b/drivers/crypto/stm32/stm32-crc32.c
    index be1bf39a317d..90a920e7f664 100644
    --- a/drivers/crypto/stm32/stm32-crc32.c
    +++ b/drivers/crypto/stm32/stm32-crc32.c
    @@ -384,8 +384,10 @@ static int stm32_crc_remove(struct platform_device *pdev)
    struct stm32_crc *crc = platform_get_drvdata(pdev);
    int ret = pm_runtime_get_sync(crc->dev);

    - if (ret < 0)
    + if (ret < 0) {
    + pm_runtime_put_noidle(crc->dev);
    return ret;
    + }

    spin_lock(&crc_list.lock);
    list_del(&crc->list);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-05-23 19:54    [W:6.518 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site