lkml.org 
[lkml]   [2022]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: Remove the redundant assignment
Hi Jiapeng,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on v5.18-rc7 next-20220520]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Jiapeng-Chong/xfs-Remove-the-redundant-assignment/20220520-120736
base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220522/202205221503.Qj3T3w3A-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/890587fbe3e3934d20fcd39effdcefedd65e6b7f
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Jiapeng-Chong/xfs-Remove-the-redundant-assignment/20220520-120736
git checkout 890587fbe3e3934d20fcd39effdcefedd65e6b7f
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/xfs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

fs/xfs/xfs_log_recover.c: In function 'xlog_recover_check_summary':
>> fs/xfs/xfs_log_recover.c:3542:42: warning: unused variable 'agfp' [-Wunused-variable]
3542 | struct xfs_agf *agfp = agfbp->b_addr;
| ^~~~
>> fs/xfs/xfs_log_recover.c:3551:42: warning: unused variable 'agi' [-Wunused-variable]
3551 | struct xfs_agi *agi = agibp->b_addr;
| ^~~


vim +/agfp +3542 fs/xfs/xfs_log_recover.c

^1da177e4c3f415 Linus Torvalds 2005-04-16 3519
^1da177e4c3f415 Linus Torvalds 2005-04-16 3520 #if defined(DEBUG)
^1da177e4c3f415 Linus Torvalds 2005-04-16 3521 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 3522 * Read all of the agf and agi counters and check that they
^1da177e4c3f415 Linus Torvalds 2005-04-16 3523 * are consistent with the superblock counters.
^1da177e4c3f415 Linus Torvalds 2005-04-16 3524 */
e89fbb5ee1893f3 Christoph Hellwig 2017-11-06 3525 STATIC void
^1da177e4c3f415 Linus Torvalds 2005-04-16 3526 xlog_recover_check_summary(
9a8d2fdbb47aaa1 Mark Tinguely 2012-06-14 3527 struct xlog *log)
^1da177e4c3f415 Linus Torvalds 2005-04-16 3528 {
934933c3eec9e4a Dave Chinner 2021-06-02 3529 struct xfs_mount *mp = log->l_mp;
934933c3eec9e4a Dave Chinner 2021-06-02 3530 struct xfs_perag *pag;
e82226138b20d4f Dave Chinner 2020-12-16 3531 struct xfs_buf *agfbp;
e82226138b20d4f Dave Chinner 2020-12-16 3532 struct xfs_buf *agibp;
^1da177e4c3f415 Linus Torvalds 2005-04-16 3533 xfs_agnumber_t agno;
5e1be0fb1a39505 Christoph Hellwig 2008-11-28 3534 int error;
^1da177e4c3f415 Linus Torvalds 2005-04-16 3535
934933c3eec9e4a Dave Chinner 2021-06-02 3536 for_each_perag(mp, agno, pag) {
934933c3eec9e4a Dave Chinner 2021-06-02 3537 error = xfs_read_agf(mp, NULL, pag->pag_agno, 0, &agfbp);
4805621a37d9b2b Christoph Hellwig 2008-11-28 3538 if (error) {
a0fa2b679ecd15b Dave Chinner 2011-03-07 3539 xfs_alert(mp, "%s agf read failed agno %d error %d",
934933c3eec9e4a Dave Chinner 2021-06-02 3540 __func__, pag->pag_agno, error);
4805621a37d9b2b Christoph Hellwig 2008-11-28 3541 } else {
9798f615ad2be48 Christoph Hellwig 2020-03-10 @3542 struct xfs_agf *agfp = agfbp->b_addr;
^1da177e4c3f415 Linus Torvalds 2005-04-16 3543 xfs_buf_relse(agfbp);
4805621a37d9b2b Christoph Hellwig 2008-11-28 3544 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 3545
934933c3eec9e4a Dave Chinner 2021-06-02 3546 error = xfs_read_agi(mp, NULL, pag->pag_agno, &agibp);
a0fa2b679ecd15b Dave Chinner 2011-03-07 3547 if (error) {
a0fa2b679ecd15b Dave Chinner 2011-03-07 3548 xfs_alert(mp, "%s agi read failed agno %d error %d",
934933c3eec9e4a Dave Chinner 2021-06-02 3549 __func__, pag->pag_agno, error);
a0fa2b679ecd15b Dave Chinner 2011-03-07 3550 } else {
370c782b98436bb Christoph Hellwig 2020-03-10 @3551 struct xfs_agi *agi = agibp->b_addr;

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-22 09:26    [W:0.068 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site