lkml.org 
[lkml]   [2022]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] cifs: Return true/false (not 1/0) from bool functions
From
Do you remember which patch caused this? Perhaps one of Dave Howell's 
iov_iter cifs patches that was temporarily in for-next? I don't see it
anymore

On 5/4/22 08:06, Yang Li wrote:
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions. This fixes the following warnings from coccicheck:
>
> ./fs/cifs/file.c:4764:9-10: WARNING: return of 0/1 in function
> cifs_release_folio() with return type bool
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> fs/cifs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index 580a847aa8b5..a9123cefd84f 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -4761,7 +4761,7 @@ static int cifs_write_begin(struct file *file, struct address_space *mapping,
> static bool cifs_release_folio(struct folio *folio, gfp_t gfp)
> {
> if (folio_test_private(folio))
> - return 0;
> + return false;
> if (folio_test_fscache(folio)) {
> if (current_is_kswapd() || !(gfp & __GFP_FS))
> return false;

\
 
 \ /
  Last update: 2022-05-22 23:11    [W:0.057 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site