Messages in this thread | | | Date | Sat, 21 May 2022 13:28:48 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v3] i2c: add support for microchip fpga i2c controllers |
| |
> > > + ret = devm_request_irq(&pdev->dev, irq, mchp_corei2c_isr, IRQF_SHARED, > > > + pdev->name, idev); > > > > Really SHARED? > > Yeah, this driver supports both the hard peripherals & soft FPGA cores. > The hard peripherals do not have shared IRQs, but we don't really have > any control over what way the interrupts are wired for the soft cores. > Worth adding a comment to explain the reason for it being shared?
Yes. Such information never hurst, I'd say.
Thanks, have a nice weekend,
Wolfram
[unhandled content-type:application/pgp-signature]
| |