lkml.org 
[lkml]   [2022]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] s390: Kconfig: Fix indentation and add comments
On Fri, 20 May 2022 10:15:38 -0700
Joe Perches <joe@perches.com> wrote:

> On Fri, 2022-05-20 at 13:57 +0200, Juerg Haefliger wrote:
> > The convention for indentation seems to be a single tab. Help text is
> > further indented by an additional two whitespaces. Fix the lines that
> > violate these rules.
> >
> > While add it, add trailing comments to endmenu statements for better
> > readability.
> []
> > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> []
> > @@ -607,7 +607,7 @@ config RANDOMIZE_BASE
> > as a security feature that deters exploit attempts relying on
> > knowledge of the location of kernel internals.
> >
> > -endmenu
> > +endmenu # "Processor type and features"
>
> An endmenu comment is relatively unusual.
>
> $ git grep '^endmenu' -- '*/Kconfig*' | wc -l
> 394
> $ git grep '^endmenu.*#' -- '*/Kconfig*' | wc -l
> 20
>
> I believe it doesn't really help readability.

Thanks for the review. Will send a v2 without that.

...Juerg

>

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-05-21 12:36    [W:0.338 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site