Messages in this thread | | | From | Huacai Chen <> | Date | Sat, 21 May 2022 17:13:45 +0800 | Subject | Re: [PATCH V11 09/22] LoongArch: Add boot and setup routines |
| |
Hi, Javier,
On Sat, May 21, 2022 at 5:06 PM Javier Martinez Canillas <javierm@redhat.com> wrote: > > Hello Huacai, > > On 5/21/22 09:37, Huacai Chen wrote: > > [snip] > > >> > >> A problem with moving to subsys_initcall_sync() is that this will delay > >> more when a display is available in the system, and just to cope up with > >> a corner case (as mentioned the common case is native drivers as module). > > OK, your method seems better, but I think moving to > > subsys_initcall_sync() can make the screen display as early as > > possible. > > > > But it doesn't cover all cases. For example, you will get the same error > if for example your native driver is built-in and efifb built as module. > > So my opinion is that instead of playing with the init call levels, is > just better for you to build your native driver as a module instead of > making it built-in. I mean moving to subsys_initcall_sync() on top of your patchset, not replacing them (Just for display earlier).
Huacai > > -- > Best regards, > > Javier Martinez Canillas > Linux Engineering > Red Hat >
| |