Messages in this thread | | | Date | Fri, 20 May 2022 10:32:47 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH v1 1/2] tools/nolibc/stdlib: Support overflow checking for older compiler versions |
| |
On Fri, May 20, 2022 at 06:29:56PM +0700, Alviro Iskandar Setiawan wrote: > On Fri, May 20, 2022 at 12:21 AM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote: > > Previously, we used __builtin_mul_overflow() to check for overflow in > > the multiplication operation in the calloc() function. However, older > > compiler versions don't support this built-in. This patch changes the > > overflow checking mechanism to make it work on any compiler version > > by using a division method to check for overflow. No functional change > > intended. While in there, remove the unused variable `void *orig`. > > > > Link: https://lore.kernel.org/lkml/20220330024114.GA18892@1wt.eu > > Suggested-by: Willy Tarreau <w@1wt.eu> > > Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org> > > Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org> > > Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org> > > tq > > -- Viro
I have queued both patches with yours and Willy Tarreau's reviews and acks. Thank you all!
Thanx, Paul
| |