lkml.org 
[lkml]   [2022]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v3 1/6] [PATCH 1/6] mm: refactor of vma_merge()
On Mon, May 16, 2022 at 02:54:00PM +0200, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter, more understandable and
> suitable for tracing of successful merges that are made possible by
> following patches in the series. Main change is the elimination of code
> duplicity in the case of merge next check. This is done by first doing
> checks and caching the results before executing the merge itself. Exit
> paths are also unified.
>
> Signed-off-by: Jakub Matěna <matenajakub@gmail.com>

Okay, this looks good:

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

I would also consider renaming 'area' to 'vma'. 'area' feels wrong to me,
but maybe it is only me.

--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2022-05-20 15:27    [W:0.213 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site