Messages in this thread | | | Date | Fri, 20 May 2022 06:51:08 -0600 | Subject | Re: [PATCHSET 0/2] Fix splice from random/urandom | From | Jens Axboe <> |
| |
On 5/20/22 12:02 AM, Christoph Hellwig wrote: > On Thu, May 19, 2022 at 01:55:26PM -0600, Jens Axboe wrote: >> I'm a bit torn on this one, because I _really_ want us to get rid of >> read/write and make everything use read_iter/write_iter. Firstly because >> it's really stupid to have two interfaces, and secondly because even >> basic things like "can we block here" doesn't work in the older >> interface without fiddling with file flags which is a non-starter for >> certain things. > > Converting everything was my initial plan, but Linus said no and just > fix whatever breaks. And compared to my initial fears the fallout > actually isn't that bad.
That's a real shame, and very unlike Linus to advocate for just breaking applications willy nilly. It would be a considerable amount of work though, but it would really be great to not have ->read/->write anymore and solely use the iter variants.
Not sure if I agree with "that bad" though looking at the number of fixups, and we'll keep finding these going forward as well...
-- Jens Axboe
| |