lkml.org 
[lkml]   [2022]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net v3] net: macb: Fix PTP one step sync support
Date


> -----Original Message-----
> From: Paolo Abeni <pabeni@redhat.com>
> Sent: Thursday, May 19, 2022 11:48 PM
> To: Harini Katakam <harinik@xilinx.com>; nicolas.ferre@microchip.com;
> davem@davemloft.net; richardcochran@gmail.com;
> claudiu.beznea@microchip.com; kuba@kernel.org; edumazet@google.com
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Michal Simek
> <michals@xilinx.com>; harinikatakamlinux@gmail.com; Radhey Shyam
> Pandey <radheys@xilinx.com>
> Subject: Re: [PATCH net v3] net: macb: Fix PTP one step sync support
>
> On Wed, 2022-05-18 at 22:37 +0530, Harini Katakam wrote:
> > PTP one step sync packets cannot have CSUM padding and insertion in SW
> > since time stamp is inserted on the fly by HW.
> > In addition, ptp4l version 3.0 and above report an error when skb
> > timestamps are reported for packets that not processed for TX TS after
> > transmission.
> > Add a helper to identify PTP one step sync and fix the above two
> > errors. Add a common mask for PTP header flag field "twoStepflag".
> > Also reset ptp OSS bit when one step is not selected.
> >
> > Fixes: ab91f0a9b5f4 ("net: macb: Add hardware PTP support")
> > Fixes: 653e92a9175e ("net: macb: add support for padding and fcs
> > computation")
> > Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> > Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
>
> I'm sorry, but I cut the -net PR to Linus too early for this, so the fix will have to
> wait for a little more (no need to repost!) and even more pause will be
> required for the net-next follow-up.
>
> Sorry for the inconvenince,

Thanks Paolo. No problem, will wait and send net-next follow up.

Regards,
Harini

\
 
 \ /
  Last update: 2022-05-20 07:36    [W:2.194 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site