lkml.org 
[lkml]   [2022]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: arch/mips/include/asm/checksum.h:195:9: error: unsupported inline asm: input with type 'unsigned long' matching output with type '__wsum' (aka 'unsigned int')
On Thu, 19 May 2022, Paul Cercueil wrote:

> About the real issue: Maybe the last "addu" in csum_tcpudp_nofold() should be
> a "daddu"?

It doesn't matter whether there is ADDU or DADDU anymore, given that
commit 198688edbf77 ("MIPS: Fix inline asm input/output type mismatch in
checksum.h used with Clang") has added a redundant 32-bit sign-extension
operation right afterwards, regressing size/performance by an extra
instruction in this performance-critical code as a workaround for a stupid
compiler.

I'm not sure though why the bot has been verifying old commit
c434b9f80b09 ("MIPS: Kconfig: add MIPS_GENERIC_KERNEL symbol") instead,
which predates the workaround. Perhaps current master also fails to build
in this file for one reason or another and bisection has misled the bot
into an unrelated commit?

Maciej

\
 
 \ /
  Last update: 2022-05-20 13:10    [W:1.621 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site