lkml.org 
[lkml]   [2022]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v5 05/13] net: pcs: add Renesas MII converter driver
    On Fri, May 20, 2022 at 09:52:41AM +0200, Clément Léger wrote:
    > > Also, as a request to unbind this driver would be disasterous to users,
    > > I think you should set ".suppress_bind_attrs = true" to prevent the
    > > sysfs bind/unbind facility being available. This doesn't completely
    > > solve the problem.
    >
    > Acked. What should I do to make it more robust ? Should I use a
    > refcount per pdev and check that in the remove() callback to avoid
    > removing the pdev if used ?

    I wonder, if you call device_link_add(ds->dev, miic->dev, DL_FLAG_AUTOREMOVE_CONSUMER),
    wouldn't that be enough to auto-unbind the DSA driver when the MII
    converter driver unbinds?

    \
     
     \ /
      Last update: 2022-05-20 10:51    [W:4.926 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site