Messages in this thread | | | Date | Fri, 20 May 2022 15:53:21 +0800 | Subject | Re: [PATCH v4] ARM: module: Add all unwind tables when load module | From | Chen Zhongjin <> |
| |
On 2022/5/17 22:19, Russell King (Oracle) wrote: > Hi, > > On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote: >> struct mod_arch_specific { >> #ifdef CONFIG_ARM_UNWIND >> - struct unwind_table *unwind[ARM_SEC_MAX]; >> + struct unwind_table unwind_list; > > Why is this not a: > > struct list_head unwind_list; > > because, from what I can tell, the _only_ member that is used in this > struct unwind_table is the "mod_list" member - so everything else is > entirely unused and redundant. > > Thanks. > Thanks for review!
I have updated it to v5 with two other fixes. Also updated it on patch tracker.
Best, Chen
| |