lkml.org 
[lkml]   [2022]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] ARM: module: Add all unwind tables when load module
From
On 2022/5/17 22:19, Russell King (Oracle) wrote:
> Hi,
>
> On Fri, Apr 01, 2022 at 09:15:34PM +0800, Chen Zhongjin wrote:
>> struct mod_arch_specific {
>> #ifdef CONFIG_ARM_UNWIND
>> - struct unwind_table *unwind[ARM_SEC_MAX];
>> + struct unwind_table unwind_list;
>
> Why is this not a:
>
> struct list_head unwind_list;
>
> because, from what I can tell, the _only_ member that is used in this
> struct unwind_table is the "mod_list" member - so everything else is
> entirely unused and redundant.
>
> Thanks.
>
Thanks for review!

I have updated it to v5 with two other fixes. Also updated it on patch tracker.

Best,
Chen

\
 
 \ /
  Last update: 2022-05-20 09:54    [W:0.191 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site