Messages in this thread | | | Date | Sat, 21 May 2022 11:34:12 +0800 (GMT+08:00) | From | 刘永志 <> | Subject | Re: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer |
| |
I'm sorry to send this to linux-iio by mistake. I will cautiously submit patches later.
> -----Original Messages----- > From: "Yongzhi Liu" <lyz_cs@pku.edu.cn> > Sent Time: 2022-05-21 11:31:02 (Saturday) > To: agross@kernel.org, bjorn.andersson@linaro.org, jic23@kernel.org, lars@metafoo.de, svarbanov@mm-sol.com, iivanov@mm-sol.com, jonathan.cameron@huawei.com > Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, fuyq@stu.pku.edu.cn, "Yongzhi Liu" <lyz_cs@pku.edu.cn> > Subject: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer > > The return value of netvsc_devinfo_get() > needs to be checked to avoid use of NULL > pointer in case of an allocation failure. > > Fixes: 0efeea5fb ("hv_netvsc: Add the support of hibernation") > > Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn> > --- > drivers/net/hyperv/netvsc_drv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index fde1c49..b1dece6 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -2671,7 +2671,10 @@ static int netvsc_suspend(struct hv_device *dev) > > /* Save the current config info */ > ndev_ctx->saved_netvsc_dev_info = netvsc_devinfo_get(nvdev); > - > + if (!ndev_ctx->saved_netvsc_dev_info) { > + ret = -ENOMEM; > + goto out; > + } > ret = netvsc_detach(net, nvdev); > out: > rtnl_unlock(); > -- > 2.7.4
| |