Messages in this thread | | | Date | Sat, 21 May 2022 09:31:03 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v2] sched/core: add forced idle accounting for cgroups |
| |
Hi Josh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tj-cgroup/for-next] [also build test WARNING on tip/sched/core tip/master v5.18-rc7 next-20220520] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Josh-Don/sched-core-add-forced-idle-accounting-for-cgroups/20220521-075311 base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220521/202205210945.s3TGKFfR-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0575a42c9f10cda618b09b949cc42fe97abea479 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Josh-Don/sched-core-add-forced-idle-accounting-for-cgroups/20220521-075311 git checkout 0575a42c9f10cda618b09b949cc42fe97abea479 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/math.h:6, from include/linux/math64.h:6, from include/linux/time64.h:5, from include/linux/restart_block.h:10, from include/linux/thread_info.h:14, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from arch/m68k/include/asm/irqflags.h:6, from include/linux/irqflags.h:16, from arch/m68k/include/asm/atomic.h:6, from include/linux/atomic.h:7, from include/linux/rcupdate.h:25, from include/linux/rculist.h:11, from include/linux/pid.h:5, from include/linux/sched.h:14, from include/linux/cgroup.h:12, from kernel/cgroup/cgroup-internal.h:5, from kernel/cgroup/rstat.c:2: kernel/cgroup/rstat.c: In function 'cgroup_base_stat_cputime_show': >> arch/m68k/include/asm/div64.h:21:17: warning: 'forceidle_time' is used uninitialized [-Wuninitialized] 21 | __n.n64 = (n); \ | ^ kernel/cgroup/rstat.c:465:28: note: 'forceidle_time' was declared here 465 | u64 __maybe_unused forceidle_time; | ^~~~~~~~~~~~~~
vim +/forceidle_time +21 arch/m68k/include/asm/div64.h
d20f5aa338dc75 Greg Ungerer 2009-02-06 12 d20f5aa338dc75 Greg Ungerer 2009-02-06 13 #define do_div(n, base) ({ \ d20f5aa338dc75 Greg Ungerer 2009-02-06 14 union { \ d20f5aa338dc75 Greg Ungerer 2009-02-06 15 unsigned long n32[2]; \ d20f5aa338dc75 Greg Ungerer 2009-02-06 16 unsigned long long n64; \ d20f5aa338dc75 Greg Ungerer 2009-02-06 17 } __n; \ d20f5aa338dc75 Greg Ungerer 2009-02-06 18 unsigned long __rem, __upper; \ ea077b1b96e073 Andreas Schwab 2013-08-09 19 unsigned long __base = (base); \ d20f5aa338dc75 Greg Ungerer 2009-02-06 20 \ d20f5aa338dc75 Greg Ungerer 2009-02-06 @21 __n.n64 = (n); \ d20f5aa338dc75 Greg Ungerer 2009-02-06 22 if ((__upper = __n.n32[0])) { \ d20f5aa338dc75 Greg Ungerer 2009-02-06 23 asm ("divul.l %2,%1:%0" \ d20f5aa338dc75 Greg Ungerer 2009-02-06 24 : "=d" (__n.n32[0]), "=d" (__upper) \ ea077b1b96e073 Andreas Schwab 2013-08-09 25 : "d" (__base), "0" (__n.n32[0])); \ d20f5aa338dc75 Greg Ungerer 2009-02-06 26 } \ d20f5aa338dc75 Greg Ungerer 2009-02-06 27 asm ("divu.l %2,%1:%0" \ d20f5aa338dc75 Greg Ungerer 2009-02-06 28 : "=d" (__n.n32[1]), "=d" (__rem) \ ea077b1b96e073 Andreas Schwab 2013-08-09 29 : "d" (__base), "1" (__upper), "0" (__n.n32[1])); \ d20f5aa338dc75 Greg Ungerer 2009-02-06 30 (n) = __n.n64; \ d20f5aa338dc75 Greg Ungerer 2009-02-06 31 __rem; \ d20f5aa338dc75 Greg Ungerer 2009-02-06 32 }) d20f5aa338dc75 Greg Ungerer 2009-02-06 33
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |