Messages in this thread | | | Date | Fri, 20 May 2022 18:15:22 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net 1/6] rxrpc: Enable IPv6 checksums on transport socket |
| |
On Fri, 20 May 2022 17:33:48 +0100 David Howells wrote: > AF_RXRPC doesn't currently enable IPv6 UDP Tx checksums on the transport > socket it opens and the checksums in the packets it generates end up 0. > > It probably should also enable IPv6 UDP Rx checksums and IPv4 UDP > checksums. The latter only seem to be applied if the socket family is > AF_INET and don't seem to apply if it's AF_INET6. IPv4 packets from an > IPv6 socket seem to have checksums anyway. > > What seems to have happened is that the inet_inv_convert_csum() call didn't > get converted to the appropriate udp_port_cfg parameters - and > udp_sock_create() disables checksums unless explicitly told not too. > > Fix this by enabling the three udp_port_cfg checksum options. > > Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket") > Reported-by: Marc Dionne <marc.dionne@auristor.com> > Signed-off-by: David Howells <dhowells@redhat.com> > Reviewed-by: Xin Long <lucien.xin@gmail.com> > Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
This is already in net.. pw build got gave up on this series. Could you resend just the other 5 patches?
| |