Messages in this thread | | | From | Andrii Nakryiko <> | Date | Fri, 20 May 2022 15:00:45 -0700 | Subject | Re: [PATCH bpf-next v2] selftests/bpf: fix some bugs in map_lookup_percpu_elem testcase |
| |
On Wed, May 18, 2022 at 8:44 AM Yonghong Song <yhs@fb.com> wrote: > > > > On 5/17/22 7:50 PM, Feng zhou wrote: > > From: Feng Zhou <zhoufeng.zf@bytedance.com> > > > > comments from Andrii Nakryiko, details in here: > > https://lore.kernel.org/lkml/20220511093854.411-1-zhoufeng.zf@bytedance.com/T/ > > > > use /* */ instead of // > > use libbpf_num_possible_cpus() instead of sysconf(_SC_NPROCESSORS_ONLN) > > use 8 bytes for value size > > fix memory leak > > use ASSERT_EQ instead of ASSERT_OK > > add bpf_loop to fetch values on each possible CPU > > > > Fixes: ed7c13776e20c74486b0939a3c1de984c5efb6aa ("selftests/bpf: add test case for bpf_map_lookup_percpu_elem") > > Signed-off-by: Feng Zhou <zhoufeng.zf@bytedance.com> > > Acked-by: Yonghong Song <yhs@fb.com>
I've fixed remaining formatting issues and added my_pid check to avoid accidental interference with other tests/processes. Applied to bpf-next, thanks.
| |