Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 2 May 2022 09:47:04 +0200 | Subject | Re: [asahilinux:asahi-soc/rtkit-sart-nvme 4/6] drivers/soc/apple/sart.c:284:4: warning: format specifies type 'unsigned long long' but the argument has type 'phys_addr_t' (aka 'unsigned int') |
| |
On Mon, May 2, 2022 at 9:34 AM Sven Peter <sven@svenpeter.dev> wrote: > On Mon, May 2, 2022, at 08:39, Arnd Bergmann wrote: > > > > to print a phys_addr_t, you should pass the address by reference and use > > the special "%pap" format string modifier. I'm not entirely sure if it should > > actually be a dma_addr_t instead of a phys_addr_t. If the type gets changed, > > the format string would become "%pad". > > I've been using %pa for all other prints in this file since v1 and just > missed this one for some reason. I'm a bit confused why the bots found this last > one only now but I'll fix it as well.
You only get a warning for 32-bit builds using 64-bit phys_addr_t, which is fairly rare, so you can't predict whether the bots will actually run into this.
Arnd
| |