Messages in this thread | | | Date | Mon, 2 May 2022 09:27:18 +0200 | Subject | Re: [PATCH v2 1/9] ARM: dts: zynq-7000: drop useless 'dma-channels/requests' properties | From | Michal Simek <> |
| |
On 4/30/22 14:18, Krzysztof Kozlowski wrote: > The pl330 DMA controller provides number of DMA channels and requests > through its registers, so duplicating this information (with a chance of > mistakes) in DTS is pointless. Additionally the DTS used always wrong > property names which causes DT schema check failures - the bindings > documented 'dma-channels' and 'dma-requests' properties without leading > hash sign. > > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Not adding acquired review tag because of significant change. > --- > arch/arm/boot/dts/zynq-7000.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi > index 47c2a4b14c06..c193264a86ff 100644 > --- a/arch/arm/boot/dts/zynq-7000.dtsi > +++ b/arch/arm/boot/dts/zynq-7000.dtsi > @@ -343,8 +343,6 @@ dmac_s: dmac@f8003000 { > <0 40 4>, <0 41 4>, > <0 42 4>, <0 43 4>; > #dma-cells = <1>; > - #dma-channels = <8>; > - #dma-requests = <4>; > clocks = <&clkc 27>; > clock-names = "apb_pclk"; > };
Acked-by: Michal Simek <michal.simek@amd.com>
If you can take it via your tree that would be great (easier for me than sending pull request with just one patch) but I can also take it.
Thanks, Michal
| |