Messages in this thread | | | Date | Mon, 2 May 2022 21:28:45 +0200 | Subject | Re: [PATCH v2 1/3] drm: Remove superfluous arg when calling to drm_fbdev_generic_setup() | From | Javier Martinez Canillas <> |
| |
On 5/2/22 20:36, Laurent Pinchart wrote: > On Mon, May 02, 2022 at 07:15:16PM +0200, Javier Martinez Canillas wrote: >> On 5/2/22 18:55, Javier Martinez Canillas wrote: >> >> [snip] >> >>>> drop the depth option to drm_fbdev_generic_setup() ? There's a FIXME >>>> comment in drm_fbdev_generic_setup() that could be related. >>> >>> A FIXME makes sense, I'll add that to when posting a v3. >> >> There's actually a FIXME already in drm_fbdev_generic_setup(), so it's >> a documented issue [0]: > > That's what I meant by "there's a FIXME" :-) It doesn't have to be > addressed by this series, but it would be good to fix it. >
doh, I misread your original email. Yes, it's the same issue as you said and something that I plan to look at some point as a follow-up.
I hope that we could just replace fbcon with a kms/systemd-consoled/foo user-space implementation before fixing all the stuff in the DRM fbdev emulation layer :)
-- Best regards,
Javier Martinez Canillas Linux Engineering Red Hat
| |