Messages in this thread | | | Date | Mon, 2 May 2022 12:00:02 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 1/3] of: overlay: add entry to of_overlay_action_name[] |
| |
On Sat, Apr 30, 2022 at 07:05:41PM -0500, frowand.list@gmail.com wrote: > From: Frank Rowand <frank.rowand@sony.com> > > The values of enum of_overlay_notify_action are used to index into > array of_overlay_action_name. Add an entry to of_overlay_action_name > for the value recently added to of_overlay_notify_action. > > Array of_overlay_action_name[] is moved into include/linux/of.h > adjacent to enum of_overlay_notify_action to make the connection > between the two more obvious if either is modified in the future. > > The only use of of_overlay_action_name is for error reporting in > overlay_notify(). All callers of overlay_notify() report the same > error, but with fewer details. Remove the redundant error reports > in the callers. > > Fixes: 067c098766c6 ("of: overlay: rework overlay apply and remove kfree()s") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Frank Rowand <frank.rowand@sony.com> > --- > drivers/of/overlay.c | 27 +++++---------------------- > include/linux/of.h | 13 +++++++++++++ > 2 files changed, 18 insertions(+), 22 deletions(-)
This isn't applying for me.
Rob
| |