Messages in this thread | | | Date | Mon, 2 May 2022 19:09:08 +0300 | Subject | Re: [PATCH v4 3/6] perf stat: Avoid printing cpus with no counters | From | Adrian Hunter <> |
| |
On 30/04/22 09:23, Ian Rogers wrote: > perf_evlist's user_requested_cpus can contain CPUs not present in any > evsel's cpus, for example uncore counters. Avoid printing the prefix and > trailing \n until the first valid counter is encountered. > > Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> --- > tools/perf/util/stat-display.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index d9629a83aa78..13f705737367 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -948,8 +948,6 @@ static void print_no_aggr_metric(struct perf_stat_config *config, > struct evsel *counter; > bool first = true; > > - if (prefix) > - fputs(prefix, config->output); > evlist__for_each_entry(evlist, counter) { > u64 ena, run, val; > double uval; > @@ -961,6 +959,8 @@ static void print_no_aggr_metric(struct perf_stat_config *config, > > id = aggr_cpu_id__cpu(cpu, /*data=*/NULL); > if (first) { > + if (prefix) > + fputs(prefix, config->output); > aggr_printout(config, counter, id, 0); > first = false; > } > @@ -972,7 +972,8 @@ static void print_no_aggr_metric(struct perf_stat_config *config, > printout(config, id, 0, counter, uval, prefix, > run, ena, 1.0, &rt_stat); > } > - fputc('\n', config->output); > + if (!first) > + fputc('\n', config->output); > } > } >
| |