Messages in this thread | | | Date | Mon, 2 May 2022 17:43:21 +0200 | From | Lennart Poettering <> | Subject | Re: [PATCH 1/2] sysctl: read() must consume poll events, not poll() |
| |
On Mo, 02.05.22 17:30, Jason A. Donenfeld (Jason@zx2c4.com) wrote:
> Just wanted to double check with you that this change wouldn't break how > you're using it in systemd for /proc/sys/kernel/hostname: > > https://github.com/systemd/systemd/blob/39cd62c30c2e6bb5ec13ebc1ecf0d37ed015b1b8/src/journal/journald-server.c#L1832 > https://github.com/systemd/systemd/blob/39cd62c30c2e6bb5ec13ebc1ecf0d37ed015b1b8/src/resolve/resolved-manager.c#L465 > > I couldn't find anybody else actually polling on it. Interestingly, it > looks like sd_event_add_io uses epoll() inside, but you're not hitting > the bug that Jann pointed out (because I suppose you're not poll()ing on > an epoll fd).
Well, if you made sure this still works, I am fine either way ;-)
Lennart
-- Lennart Poettering, Berlin
| |