Messages in this thread Patch in this message | | | From | Christophe Leroy <> | Subject | Re: [PATCH] tty: hvcs: simplify if-if to if-else | Date | Mon, 2 May 2022 14:33:44 +0000 |
| |
Le 24/04/2022 à 11:13, Wan Jiabing a écrit : > Use if and else instead of if(A) and if (!A) and fix a coding style. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Did you run 'checkpatch' on your patch ?
Should be
if (something) do_something(); else do_something_else();
or
if (something) { do_something(); } else { do_something_else(); do_more(); }
However, are you sure that those two things are going together and are worth an if/else ? Did you look at commit 33f0f88f1c51ae5c2d593d26960c760ea154c2e2 ?
> --- > drivers/tty/hvc/hvcs.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c > index 245da1dfd818..9b7e8246a464 100644 > --- a/drivers/tty/hvc/hvcs.c > +++ b/drivers/tty/hvc/hvcs.c > @@ -581,10 +581,9 @@ static int hvcs_io(struct hvcs_struct *hvcsd) > > spin_unlock_irqrestore(&hvcsd->lock, flags); > /* This is synch -- FIXME :js: it is not! */ > - if(got) > + if (got) > tty_flip_buffer_push(&hvcsd->port); > - > - if (!got) { > + else { > /* Do this _after_ the flip_buffer_push */ > spin_lock_irqsave(&hvcsd->lock, flags); > vio_enable_interrupts(hvcsd->vdev);
| |