lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id
    Date
    > From: Jason Wang <jasowang@redhat.com>
    > Sent: Friday, April 15, 2022 6:01 AM
    > To: Eli Cohen <elic@nvidia.com>; mst@redhat.com
    > Cc: virtualization@lists.linux-foundation.org; linux-kernel@vger.kernel.org; si-wei.liu@oracle.com
    > Subject: Re: [PATCH 2/3] virtio_net: Add control VQ struct to carry vlan id
    >
    >
    > 在 2022/4/11 20:29, Eli Cohen 写道:
    > > Add structure to define the payload of control VQ messages carrying the
    > > configured vlan ID. It will be used in subsequent patches of this
    > > series.
    > >
    > > Signed-off-by: Eli Cohen <elic@nvidia.com>
    > > ---
    > > include/uapi/linux/virtio_net.h | 3 +++
    > > 1 file changed, 3 insertions(+)
    > >
    > > diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
    > > index 3f55a4215f11..b94a405fa8d2 100644
    > > --- a/include/uapi/linux/virtio_net.h
    > > +++ b/include/uapi/linux/virtio_net.h
    > > @@ -270,6 +270,9 @@ struct virtio_net_ctrl_mac {
    > > #define VIRTIO_NET_CTRL_VLAN 2
    > > #define VIRTIO_NET_CTRL_VLAN_ADD 0
    > > #define VIRTIO_NET_CTRL_VLAN_DEL 1
    > > +struct virtio_net_ctrl_vlan {
    > > + __virtio16 id;
    > > +};
    >
    >
    > It looks to me there's no need to bother uAPI and we can simply use
    > __virtio16 in patch 3?
    >

    Sure

    > Thanks
    >
    >
    > >
    > > /*
    > > * Control link announce acknowledgement

    \
     
     \ /
      Last update: 2022-05-02 07:40    [W:3.047 / U:0.616 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site