lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/5] bus: mhi: host: Rename process_db callback to ring_db
Date
"process_db" might be confusing at times as it also implies that the
function is used to process the doorbells from the endpoint device.
So rename it to "ring_db" to make it clear that it is only used to ring
doorbell to the device.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/bus/mhi/host/init.c | 8 ++++----
drivers/bus/mhi/host/internal.h | 2 +-
drivers/bus/mhi/host/main.c | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c
index e43e2e145871..50d2a1f66e5e 100644
--- a/drivers/bus/mhi/host/init.c
+++ b/drivers/bus/mhi/host/init.c
@@ -669,9 +669,9 @@ static int parse_ev_cfg(struct mhi_controller *mhi_cntrl,
goto error_ev_cfg;

if (mhi_event->db_cfg.brstmode == MHI_DB_BRST_ENABLE)
- mhi_event->db_cfg.process_db = mhi_db_brstmode;
+ mhi_event->db_cfg.ring_db = mhi_db_brstmode;
else
- mhi_event->db_cfg.process_db = mhi_db_brstmode_disable;
+ mhi_event->db_cfg.ring_db = mhi_db_brstmode_disable;

mhi_event->data_type = event_cfg->data_type;

@@ -806,9 +806,9 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
}

if (mhi_chan->db_cfg.brstmode == MHI_DB_BRST_ENABLE)
- mhi_chan->db_cfg.process_db = mhi_db_brstmode;
+ mhi_chan->db_cfg.ring_db = mhi_db_brstmode;
else
- mhi_chan->db_cfg.process_db = mhi_db_brstmode_disable;
+ mhi_chan->db_cfg.ring_db = mhi_db_brstmode_disable;

mhi_chan->configured = true;

diff --git a/drivers/bus/mhi/host/internal.h b/drivers/bus/mhi/host/internal.h
index b10a99f8200c..3305f4d93580 100644
--- a/drivers/bus/mhi/host/internal.h
+++ b/drivers/bus/mhi/host/internal.h
@@ -142,7 +142,7 @@ struct db_cfg {
u32 pollcfg;
enum mhi_db_brst_mode brstmode;
dma_addr_t db_val;
- void (*process_db)(struct mhi_controller *mhi_cntrl,
+ void (*ring_db)(struct mhi_controller *mhi_cntrl,
struct db_cfg *db_cfg, void __iomem *io_addr,
dma_addr_t db_val);
};
diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c
index 7da5a16d721b..c46bd2dd546b 100644
--- a/drivers/bus/mhi/host/main.c
+++ b/drivers/bus/mhi/host/main.c
@@ -112,7 +112,7 @@ void mhi_ring_er_db(struct mhi_event *mhi_event)
{
struct mhi_ring *ring = &mhi_event->ring;

- mhi_event->db_cfg.process_db(mhi_event->mhi_cntrl, &mhi_event->db_cfg,
+ mhi_event->db_cfg.ring_db(mhi_event->mhi_cntrl, &mhi_event->db_cfg,
ring->db_addr, le64_to_cpu(*ring->ctxt_wp));
}

@@ -141,7 +141,7 @@ void mhi_ring_chan_db(struct mhi_controller *mhi_cntrl,
dma_wmb();
*ring->ctxt_wp = cpu_to_le64(db);

- mhi_chan->db_cfg.process_db(mhi_cntrl, &mhi_chan->db_cfg,
+ mhi_chan->db_cfg.ring_db(mhi_cntrl, &mhi_chan->db_cfg,
ring->db_addr, db);
}

--
2.25.1
\
 
 \ /
  Last update: 2022-05-02 12:43    [W:0.092 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site