Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 2 May 2022 10:52:59 +0200 | Subject | Re: [v5 00/14] Add support for Bosch BNO055 IMU |
| |
On Mon, May 2, 2022 at 10:31 AM Andrea Merello <andrea.merello@gmail.com> wrote: > Il giorno lun 2 mag 2022 alle ore 09:48 Andy Shevchenko > <andy.shevchenko@gmail.com> ha scritto:
...
> > > BTW I have also gone through some kernel-robot reports; they also > > > state "If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot <lkp@intel.com>". I'd say that it would > > > be OK to add this tag to a patch that just fixes what is reported, but > > > I'm unsure whether it is appropriate to add this tag to the patches in > > > my series, because they add the code and the fix at once. Any advice > > > here? > > > > For this we specifically amended the kernel documentation recently. > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes > > > > "The tag is intended for bugs; please do not use it to credit feature requests." > > Well, no any feature request to credit here; a bug and its fix are > involved. Sounds more like a "yes" so far.. But it wouldn't be clear > what the robot did report indeed (squashed bugs and fixes).. Maybe a > "thank" in the cover letter also to it would suffice?
The reported from bots should be used when your patches.changes induced by those reports, it seems otherwise in your case.,
-- With Best Regards, Andy Shevchenko
| |