Messages in this thread | | | Date | Thu, 19 May 2022 10:34:40 +0200 | From | Stefano Garzarella <> | Subject | Re: [PATCH V5 9/9] virtio: use WARN_ON() to warn illegal status value |
| |
On Wed, May 18, 2022 at 11:59:51AM +0800, Jason Wang wrote: >We used to use BUG_ON() in virtio_device_ready() to detect illegal >status value, this seems sub-optimal since the value is under the >control of the device. Switch to use WARN_ON() instead. > >Cc: Thomas Gleixner <tglx@linutronix.de> >Cc: Peter Zijlstra <peterz@infradead.org> >Cc: "Paul E. McKenney" <paulmck@kernel.org> >Cc: Marc Zyngier <maz@kernel.org> >Cc: Halil Pasic <pasic@linux.ibm.com> >Cc: Cornelia Huck <cohuck@redhat.com> >Cc: Vineeth Vijayan <vneethv@linux.ibm.com> >Cc: Peter Oberparleiter <oberpar@linux.ibm.com> >Cc: linux-s390@vger.kernel.org >Signed-off-by: Jason Wang <jasowang@redhat.com> >--- > include/linux/virtio_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
| |