Messages in this thread | | | Date | Thu, 19 May 2022 17:51:10 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] net: atlantic: Avoid out-of-bounds indexing |
| |
On Thu, 19 May 2022 03:09:50 +0200 Nikolaus Vladutescu-Zopp wrote: > A UBSAN warning is observed on atlantic driver: > > [ 16.257086] UBSAN: array-index-out-of-bounds in > drivers/net/ethernet/aquantia/atlantic/aq_nic.c:1268:48 > [ 16.257090] index 8 is out of range for type 'aq_vec_s *[8]' > > The index is assigned right before breaking out the loop, so there's no > actual deferencing happening. > So only use the index inside the loop to fix the issue. > > Same issue was observed and corrected in two other places. > > BugLink: https://bugs.launchpad.net/bugs/1958770 > Suggested-by: bsdz <blairuk@gmail.com> > Suggested-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > Tested-by: Nikolaus Vladutescu-Zopp <nikolaus@vladutescu-zopp.com> > Signed-off-by: Nikolaus Vladutescu-Zopp <nikolaus@vladutescu-zopp.com>
The patch does not apply, please rebase on net/master:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
and repost. Please use [PATCH net] as the subject prefix. Please add a Fixes tag, if possible. Please replace "bsdz" with the person's name or remove that tag.
| |