Messages in this thread | | | Date | Thu, 19 May 2022 21:02:22 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2] net: phy: DP83822: enable rgmii mode if phy_interface_is_rgmii |
| |
On Thu, May 19, 2022 at 08:50:56PM +0200, Tommaso Merciai wrote: > RGMII mode can be enable from dp83822 straps, and also writing bit 9 > of register 0x17 - RMII and Status Register (RCSR). > When phy_interface_is_rgmii rgmii mode must be enabled, same for > contrary, this prevents malconfigurations of hw straps > > References: > - https://www.ti.com/lit/gpn/dp83822i p66 > > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > Co-developed-by: Michael Trimarchi <michael@amarulasolutions.com> > Suggested-by: Alberto Bianchi <alberto.bianchi@amarulasolutions.com> > Tested-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > --- > Changes since v1: > - Improve commit msg > - Add definition of bit 9 reg rcsr (rgmii mode en) > - Handle case: phy_interface_is_rgmii is false
Please don't post a new version for at least 24 hours. Give people time to review the code and make comments.
Andrew
| |