lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [RFC net-next] dt-bindings: net: xilinx: document xilinx emaclite driver binding
Date
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, May 13, 2022 2:23 PM
> To: Radhey Shyam Pandey <radheys@xilinx.com>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; Harini Katakam
> <harinik@xilinx.com>
> Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; git <git@xilinx.com>
> Subject: Re: [RFC net-next] dt-bindings: net: xilinx: document xilinx emaclite
> driver binding
>
> On 12/05/2022 18:39, Radhey Shyam Pandey wrote:
> > Add basic description for the xilinx emaclite driver DT bindings.
> >
> > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> > ---
> > .../bindings/net/xlnx,emaclite.yaml | 60 +++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/net/xlnx,emaclite.yaml
>
> Why is this RFC? Do you expect DT maintainers review or not? Maybe there is
> no point for us to review something which is not going to be applied?

I intentionally made it RFC so that all aspects are reviewed as this driver didn't
had an existing binding. I will send out next version with below comment
addressed. Thanks!
>
> >
> > diff --git a/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml
> > b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml
> > new file mode 100644
> > index 000000000000..a3e2a0e89b24
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/xlnx,emaclite.yaml
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/xlnx,emaclite.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Xilinx Emaclite Ethernet controller
> > +
> > +maintainers:
> > + - Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> > + - Harini Katakam <harini.katakam@xilinx.com>
> > +
>
> You should include ethernet controller schema.
>
> > +properties:
> > + compatible:
> > + enum:
> > + - xlnx,opb-ethernetlite-1.01.a
> > + - xlnx,opb-ethernetlite-1.01.b
> > + - xlnx,xps-ethernetlite-1.00.a
> > + - xlnx,xps-ethernetlite-2.00.a
> > + - xlnx,xps-ethernetlite-2.01.a
> > + - xlnx,xps-ethernetlite-3.00.a
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + phy-handle: true
> > +
> > + local-mac-address: true
> > +
> > + xlnx,tx-ping-pong:
> > + type: boolean
> > + description: hardware supports tx ping pong buffer.
> > +
> > + xlnx,rx-ping-pong:
> > + type: boolean
> > + description: hardware supports rx ping pong buffer.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - phy-handle
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + axi_ethernetlite_1: ethernet@40e00000 {
> > + compatible = "xlnx,xps-ethernetlite-3.00.a";
>
> 4-space indentation for DTS, please.
>
> > + interrupt-parent = <&axi_intc_1>;
> > + interrupts = <1 0>;
> > + local-mac-address = [00 0a 35 00 00 00];
> > + phy-handle = <&phy0>;
> > + reg = <0x40e00000 0x10000>;
> > + xlnx,rx-ping-pong;
> > + xlnx,tx-ping-pong;
> > + };
>
>
> Best regards,
> Krzysztof
\
 
 \ /
  Last update: 2022-05-18 17:50    [W:0.443 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site