Messages in this thread | | | From | Vincent MAILHOL <> | Date | Thu, 19 May 2022 00:38:51 +0900 | Subject | Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c |
| |
On Wed. 18 May 2022 at 23:59, Oliver Hartkopp <socketcan@hartkopp.net> wrote: > On 18.05.22 16:38, Oliver Hartkopp wrote: > > On 18.05.22 16:36, Marc Kleine-Budde wrote: > >> On 18.05.2022 16:33:58, Oliver Hartkopp wrote: > > > >>> I would suggest to remove the Kconfig entry but not all the code > >>> inside the > >>> drivers, so that a volunteer can convert the LED support based on the > >>> existing trigger points in the drivers code later. > >> > >> The generic netdev LED trigger code doesn't need any support in the > >> netdev driver. > > > > Oh! Yes, then it could be removed. Sorry for not looking that deep into it. > > I can send a patch for this removal too. That's an easy step which might > get into 5.19 then.
OK, go ahead. On my side, I will start to work on the other changes either next week or next next week, depending on my mood.
| |