lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] fuse: return the more nuanced writeback error on close()
On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote:

> + /* return more nuanced writeback errors */
> if (err)
> - return err;
> + return filemap_check_wb_err(file->f_mapping, 0);
>
> err = 0;

As an aside, what the hell is that err = 0 about? Before or after
that patch, that is - "let's make err zero, in case it had somehow
magically changed ceased to be so since if (err) bugger_off just above"?

\
 
 \ /
  Last update: 2022-05-18 16:52    [W:0.038 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site