lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2] staging: axis-fifo: fix indentation according to checkpatch.pl
On Wed, May 18, 2022 at 01:27:09AM +0300, Uri Arev wrote:
> (My first patch!)
>

Don't put this kind of stuff into the permanent git log. :P

> scripts/checkpatch.pl warned about an indentation problem in
> the axis-fifo.c file.
>
> Checkpatch warning:
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Uri Arev <me@wantyapps.xyz>
> ---
^^^
If you're sending a v2 patch then put a note here under the --- cut
off to say what changed since the previous version:

---
v2: something something blah blah blah

> drivers/staging/axis-fifo/axis-fifo.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index dfd2b357f484..51ce48e68e27 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -383,10 +383,10 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
> */
> mutex_lock(&fifo->read_lock);
> ret = wait_event_interruptible_timeout(fifo->read_queue,
> - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> - (read_timeout >= 0) ?
> - msecs_to_jiffies(read_timeout) :
> - MAX_SCHEDULE_TIMEOUT);
> + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> + (read_timeout >= 0) ?
> + msecs_to_jiffies(read_timeout) :
> + MAX_SCHEDULE_TIMEOUT);

This is too far to the right now. It was basically fine to start with.
Just ignore checkpatch this time.

regards,
dan carpenter

\
 
 \ /
  Last update: 2022-05-18 07:42    [W:0.040 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site