lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch
Le Wed, 18 May 2022 15:05:03 +0300,
Vladimir Oltean <olteanv@gmail.com> a écrit :

> On Tue, May 17, 2022 at 08:59:24PM -0500, Rob Herring wrote:
> > On Wed, May 11, 2022 at 06:33:37PM +0300, Vladimir Oltean wrote:
> > > On Wed, May 11, 2022 at 10:22:21AM -0500, Rob Herring wrote:
> > > > > +patternProperties:
> > > > > + "^ethernet-ports$":
> > > >
> > > > Move to 'properties', not a pattern.
> > > >
> > > > With that,
> > > >
> > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > >
> > > Even if it should have been "^(ethernet-)?ports$"?
> >
> > Why? Allowing 'ports' is for existing users. New ones don't need the
> > variability and should use just 'ethernet-ports'.
> >
> > Rob
>
> Yeah, ok, somehow the memo that new DSA drivers shouldn't support "ports"
> didn't reach me. They invariably will though, since the DSA framework is
> the main parser of the property, and that is shared by both old and new
> drivers.

Should also the subnodes of "ethernet-ports" use the
"ethernet-port@[0-9]*" naming ? Or keeping the existing pattern is ok
(ie "^(ethernet-)?port@[0-4]$") ?

Thanks,

--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com

\
 
 \ /
  Last update: 2022-05-18 14:49    [W:1.710 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site