lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net v1 2/2] net: dsa: lantiq_gswip: Fix typo in gswip_port_fdb_dump() error print
On Tue, May 17, 2022 at 09:40:15PM +0200, Martin Blumenstingl wrote:
> gswip_port_fdb_dump() reads the MAC bridge entries. The error message
> should say "failed to read mac bridge entry". While here, also add the
> index to the error print so humans can get to the cause of the problem
> easier.
>
> Fixes: 58c59ef9e930c4 ("net: dsa: lantiq: Add Forwarding Database access")
> Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

> drivers/net/dsa/lantiq_gswip.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 0c313db23451..8af4def38a98 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1426,8 +1426,9 @@ static int gswip_port_fdb_dump(struct dsa_switch *ds, int port,
>
> err = gswip_pce_table_entry_read(priv, &mac_bridge);
> if (err) {
> - dev_err(priv->dev, "failed to write mac bridge: %d\n",
> - err);
> + dev_err(priv->dev,
> + "failed to read mac bridge entry %d: %d\n",
> + i, err);
> return err;
> }
>
> --
> 2.36.1
>

\
 
 \ /
  Last update: 2022-05-18 13:40    [W:0.141 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site